GH-1201: Native BatchMessageListener Support #1202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves spring-projects#1201 Support de-batching producer batches to a `List<Meessage>` with native `BatchMessageListener`s; previously this was only possible with `@RabbitListener` which does the debatching itself.
|
Not sure if related, but posting anyway since it has failed: |
|
Yeah - looks like a race in that test; rebuilding "solved" it 😄 |
spring-projects#1202 (comment) The test has a very short timeout; there is a race such that the channel won't be physically closed if we don't get the `ConsumeOK` in time. This won't really cause a problem in a real application, but this change will prevent the test from sporadically failing.
artembilan
pushed a commit
that referenced
this pull request
May 18, 2020
Resolves #1201 Support de-batching producer batches to a `List<Meessage>` with native `BatchMessageListener`s; previously this was only possible with `@RabbitListener` which does the debatching itself. * Fix race in test. #1202 (comment) The test has a very short timeout; there is a race such that the channel won't be physically closed if we don't get the `ConsumeOK` in time. This won't really cause a problem in a real application, but this change will prevent the test from sporadically failing. # Conflicts: # src/reference/asciidoc/amqp.adoc
|
... and cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1201
Support de-batching producer batches to a
List<Meessage>with nativeBatchMessageListeners; previously this was only possible with@RabbitListenerwhich does the debatching itself.cherry-pick to 2.2.x