Catch exception when EventSender stopped

[Z-Beatles]

org.springframework.amqp.rabbit.logback.AmqpAppender.java

protected class EventSender implements Runnable {
	@Override
	public void run() {
		try {
			RabbitTemplate rabbitTemplate = new RabbitTemplate(AmqpAppender.this.connectionFactory)
			while (true) {
				final Event event = AmqpAppender.this.events.take();

				MessageProperties amqpProps = prepareMessageProperties(event);

				String routingKey = AmqpAppender.this.routingKeyLayout.doLayout(event.getEvent());

				sendOneEncoderPatternMessage(rabbitTemplate, routingKey);

				doSend(rabbitTemplate, event, event.getEvent(), name, amqpProps, routingKey);
			}
		}
		catch (InterruptedException e) {
			Thread.currentThread().interrupt();
		}
	}
}
...

Any exceptions in this while(true){} code block will be lost (except InterruptedException).

For example, when sending a message using a custom LoggingLayout to encodeMessage, any exceptions thrown from doLayout() will not be caught. The sending thread will stop and we have no way of knowing what went wrong.

[pivotal-issuemaster]

@Z-Beatles Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

[pivotal-issuemaster]

@Z-Beatles Thank you for signing the Contributor License Agreement!

[artembilan]

Any chances to have some test-case on the matter?
Thanks

[Z-Beatles]

I have tried to provide a test-case but it affects other test-case. The problem is as I described, EventSender-thread missing catch exception. Hope to get help.

[artembilan]

I'm OK with the fix then since we need to release today.

@garyrussell , WDYT?