Skip to content

Fix misused 'end()' in examples #3902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

acktsap
Copy link
Contributor

@acktsap acktsap commented May 3, 2021

use() can be used in FlowJobBuilder usage. Similar with #3889.

`use()` should be used in `FlowJobBuilder` usage.
@@ -77,7 +77,6 @@ public Job footballJob() {
.start(playerLoad())
.next(gameLoad())
.next(playerSummarization())
.end()
Copy link
Contributor Author

@acktsap acktsap May 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be used if playerLoad() is flow. But it seems that playerLoad() is step according to the context.

@fmbenhassine fmbenhassine added this to the 4.3.3 milestone May 4, 2021
@fmbenhassine fmbenhassine changed the title Fix misused 'use()' in examples Fix misused 'end()' in examples May 18, 2021
fmbenhassine pushed a commit that referenced this pull request May 18, 2021
`end()` should be used with `FlowJobBuilder`.

Issue #3902
@fmbenhassine
Copy link
Contributor

Rebased and merged as 63cfc07. Thank you for your contribution!

@fmbenhassine fmbenhassine added the for: backport-to-4.2.x Issues that will be back-ported to the 4.2.x line label May 18, 2021
fmbenhassine pushed a commit that referenced this pull request May 18, 2021
`end()` should be used with `FlowJobBuilder`.

Issue #3902
fmbenhassine pushed a commit that referenced this pull request May 18, 2021
`end()` should be used with `FlowJobBuilder`.

Issue #3902
@acktsap acktsap deleted the topic/fix-invalid-example-code branch August 10, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for: backport-to-4.2.x Issues that will be back-ported to the 4.2.x line in: documentation pr-for: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants