Use immutable collections instead of creating unnecessary collection objects #4003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -160,7 +160,7 @@ public Map<String, Object> getJobParameters() { | |||
|
|
|||
| @SuppressWarnings({"rawtypes", "unchecked"}) | |||
| public Map<String, Object> getPartitionPlan() { | |||
There was a problem hiding this comment.
This method was removed in e5c752b, I will omit this change and its related test on merge.
|
Rebased and merged as d9bf57e. Thank you for your contribution! |
fmbenhassine
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a collection is created but not added, it can be refactored into an immutable (static empty) collection.
But in this case, I excluded it. For example, when using new ArrayList to convert Set to List ..
Is there something I missed?