Skip to content

Fail with exception if management.server.address is set but actuator is on the same port #22187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
philwebb opened this issue Jul 1, 2020 · 1 comment
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@philwebb
Copy link
Member

philwebb commented Jul 1, 2020

As discovered in #22142, it's possible to have a management.server.address that doesn't get applied if the ManagementPortType is SAME. It would be better if we failed hard instead of ignoring the property.

@philwebb philwebb added the type: enhancement A general enhancement label Jul 1, 2020
@philwebb philwebb changed the title Fail with exception if management.server.address is set but actuator is on the same point Fail with exception if management.server.address is set but actuator is on the same port Jul 1, 2020
@philwebb philwebb added this to the 2.4.x milestone Jul 1, 2020
@pcornelissen
Copy link

Just to reiterate, it may be also a good idea to add a note in the documentation of management.server.port that it requires server.port to be set when the real port is on a different port and management.server.port is supposed to be 8080.
This is a very hard to track down bug when your settings are ignored in the way it is now.
Or maybe you should force server.port to be set when the management.server.port is set, just to be safe. This would make things easier to document and shouldn't be a big burden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants