Skip to content

Add global optional config data opt-out #23097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
philwebb opened this issue Aug 26, 2020 · 3 comments
Closed

Add global optional config data opt-out #23097

philwebb opened this issue Aug 26, 2020 · 3 comments
Assignees
@philwebb
Labels
theme: config-data Issues related to the configuration theme type: enhancement A general enhancement
Milestone
2.4.0-M3

Comments

@philwebb
Copy link
Member

The recently introduced optional: prefix causes problems for Spring Cloud and likely for some of our users as well. We should offer a quick way to opt-out. One idea would be a spring.config.on-import-not-found=WARN/IGNORE/FAIL property.
@philwebb philwebb self-assigned this Aug 26, 2020
@philwebb philwebb added the type: enhancement A general enhancement label Aug 26, 2020
@philwebb philwebb added this to the 2.4.x milestone Aug 26, 2020
@philwebb philwebb added the theme: config-data Issues related to the configuration theme label Aug 26, 2020
@philwebb
Copy link
Member Author

I went with a slightly simpler boolean property in the end.

philwebb added a commit that referenced this issue Aug 27, 2020
@philwebb
Fix global optional config data opt-out test
a2530ad 
See gh-23097
@wilkinsona
Copy link
Member

In the interests of future-proofing things, I wonder if we should use an enum with two values rather than a boolean?

@wilkinsona wilkinsona modified the milestones: 2.4.x, 2.4.0-M3 Aug 27, 2020
@wilkinsona wilkinsona added the for: team-attention An issue we'd like other members of the team to review label Aug 27, 2020
@philwebb philwebb reopened this Aug 27, 2020
@philwebb
Copy link
Member Author

spring.config.on-location-not-found WARN/IGNORE/FAIL

@philwebb philwebb reopened this Aug 28, 2020
@philwebb philwebb removed the for: team-attention An issue we'd like other members of the team to review label Aug 28, 2020
spencergibb added a commit to spring-cloud/spring-cloud-config that referenced this issue Aug 29, 2020
@spencergibb
Sets spring.config.on-location-not-found=ignore for config server.
8b15c3f 
See spring-projects/spring-boot#23097
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
theme: config-data Issues related to the configuration theme type: enhancement A general enhancement
Projects
None yet
Milestone
2.4.0-M3
Development

No branches or pull requests
2 participants
@philwebb @wilkinsona