Skip to content

Change favicon default StaticResourceLocation #23126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wimdeblauwe opened this issue Aug 28, 2020 · 1 comment
Closed

Change favicon default StaticResourceLocation #23126

wimdeblauwe opened this issue Aug 28, 2020 · 1 comment
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@wimdeblauwe
Copy link
Contributor

Currently, in org.springframework.boot.autoconfigure.security.StaticResourceLocation, there is only favicon.ico support. Given that favicons can be SVG images now as well, it might be good to add support for those?

I believe just changing:

FAVICON("/**/favicon.ico");

to

FAVICON("/**/favicon.ico", "/**/favicon.svg");

should be enough?

(Note sure why there is /** in there. Aren't favicons located at the root always?)

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 28, 2020
@philwebb
Copy link
Member

There's an issue about the /**/ path open in #22833

@philwebb philwebb added the for: team-attention An issue we'd like other members of the team to review label Aug 28, 2020
@philwebb philwebb added type: enhancement A general enhancement and removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels Sep 16, 2020
@philwebb philwebb added this to the 2.4.x milestone Sep 16, 2020
@bclozel bclozel changed the title Support favicon.svg in StaticResourceLocation Change favicon default StaticResourceLocation Oct 23, 2020
@bclozel bclozel self-assigned this Oct 23, 2020
@bclozel bclozel modified the milestones: 2.4.x, 2.4.0-RC1 Oct 23, 2020
bclozel added a commit that referenced this issue Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants