Skip to content

Rationalize Logback logging properties #23609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
philwebb opened this issue Oct 7, 2020 · 2 comments
Closed

Rationalize Logback logging properties #23609

philwebb opened this issue Oct 7, 2020 · 2 comments
Assignees
Labels
status: noteworthy A noteworthy issue to call out in the release notes type: enhancement A general enhancement
Milestone

Comments

@philwebb
Copy link
Member

philwebb commented Oct 7, 2020

The current property names are a bit of a mess and it would be good to find better alternatives before we merge #23540

@philwebb philwebb added this to the 2.4.x milestone Oct 7, 2020
@philwebb philwebb added status: noteworthy A noteworthy issue to call out in the release notes type: enhancement A general enhancement labels Oct 7, 2020
@philwebb philwebb self-assigned this Oct 20, 2020
@philwebb
Copy link
Member Author

philwebb commented Oct 20, 2020

DefaultLogbackConfiguration

logging.pattern.console 
logging.pattern.file 
logging.file.clean-history-on-start 
logging.pattern.rolling-file-name 
logging.file.max-size 
logging.file.max-history
logging.file.total-size-cap


LogFile                                                                    Logback     Log4J    JUL

LOG_FILE                           logging.file.name                       x            x        x
LOG_PATH                           logging.file.path                       x            x        x


LoggingSystemProperties                                                    Logback     Log4J    JUL
 
EXCEPTION_CONVERSION_WORD          logging.exception-conversion-word       X            X         -
PID                                                                        X            X         -
CONSOLE_LOG_PATTERN                logging.pattern.console                 X            X         -
FILE_LOG_PATTERN                   logging.pattern.file                    X            X         -
FILE_CLEAN_HISTORY_ON_START        logging.file.clean-history-on-start     X            -         -
FILE_MAX_HISTORY                   logging.file.max-history                X            -         -
FILE_MAX_SIZE                      logging.file.max-size                   X            -         -
FILE_TOTAL_SIZE_CAP                logging.file.total-size-cap             X            -         -
LOG_LEVEL_PATTERN                  logging.pattern.level                   X            X         -
LOG_DATEFORMAT_PATTERN             logging.pattern.dateformat              X            X         -
ROLLING_FILE_NAME_PATTERN          logging.pattern.rolling-file-name       X            -         -

@philwebb philwebb changed the title Rationalize properties in DefaultLogbackConfiguration Rationalize Logback logging properties Oct 22, 2020
@philwebb philwebb modified the milestones: 2.4.x, 2.4.0-RC1 Oct 22, 2020
@philwebb
Copy link
Member Author

This issue is noteworthy because of the property renames (see the commit message)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: noteworthy A noteworthy issue to call out in the release notes type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant