Skip to content

Move R2DBC ConnectionFactoryBuilder and associated classes into spring-boot #25492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wilkinsona opened this issue Mar 4, 2021 · 0 comments
Closed

Move R2DBC ConnectionFactoryBuilder and associated classes into spring-boot #25492

wilkinsona opened this issue Mar 4, 2021 · 0 comments
Assignees
@snicoll @wilkinsona
Labels
theme: datasource Issues relating to data sources type: enhancement A general enhancement
Milestone
2.5.0-M3

Comments

@wilkinsona
Copy link
Member

wilkinsona commented Mar 4, 2021 •
edited
Loading

The spring-boot module contains DataSourceBuilder for JDBC but the equivalent class for R2DBC, ConnectionFactoryBuilder, is in spring-boot-autoconfigure. For consistency, we should move the builder and some of its associated classes (EmbeddedDatabaseConnection, for example) into spring-boot. Having a R2DBC EmbeddedDatabaseConnection class in spring-boot will help with #24741 as it could be used to detect a ConnectionFactory for an embedded database when determining what action to take based on the initialization mode.
@wilkinsona wilkinsona added type: enhancement A general enhancement theme: datasource Issues relating to data sources labels Mar 4, 2021
@wilkinsona wilkinsona added this to the 2.5.x milestone Mar 4, 2021
snicoll added a commit to snicoll/spring-boot that referenced this issue Mar 9, 2021
@snicoll
Promote ConnectionFactoryBuilder to the "spring-boot" module
c386e2b 
Closes spring-projectsgh-25492
wilkinsona pushed a commit to wilkinsona/spring-boot that referenced this issue Mar 9, 2021
@snicoll @wilkinsona
Promote ConnectionFactoryBuilder to the "spring-boot" module
23acab7 
Closes spring-projectsgh-25492
wilkinsona pushed a commit to wilkinsona/spring-boot that referenced this issue Mar 11, 2021
@snicoll @wilkinsona
Promote ConnectionFactoryBuilder to the "spring-boot" module
438ead5 
Closes spring-projectsgh-25492
@wilkinsona wilkinsona modified the milestones: 2.5.x, 2.5.0-M3 Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

@wilkinsona wilkinsona

Labels
theme: datasource Issues relating to data sources type: enhancement A general enhancement
Projects
None yet
Milestone
2.5.0-M3
Development

No branches or pull requests
2 participants
@snicoll @wilkinsona