Skip to content

Flattened VCAP_SERVICES properties are not sanitized by default #28085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mbhave opened this issue Sep 21, 2021 · 1 comment
Closed

Flattened VCAP_SERVICES properties are not sanitized by default #28085

mbhave opened this issue Sep 21, 2021 · 1 comment
Labels
type: bug A general bug
Milestone
2.4.12

Comments

@mbhave
Copy link
Contributor

mbhave commented Sep 21, 2021

We sanitize vcap_services but CloudFoundryVcapEnvironmentPostProcessor converts them to vcap.services.* which should also be sanitized.
@mbhave mbhave added this to the 2.4.x milestone Sep 21, 2021
@mbhave mbhave added the type: bug A general bug label Sep 21, 2021
@wilkinsona wilkinsona changed the title Sanitize flattened VCAP_SERVICES properties Flattened VCAP_SERVICES properties are not sanitized by default Sep 22, 2021
@mbhave mbhave added the for: team-meeting An issue we'd like to discuss as a team to make progress label Sep 22, 2021
@philwebb
Copy link
Member

We're going to add vcap.services to the sanitizer.

@philwebb philwebb removed the for: team-meeting An issue we'd like to discuss as a team to make progress label Oct 13, 2021
@philwebb philwebb mentioned this issue Oct 14, 2021
Closed
@philwebb philwebb modified the milestones: 2.4.x, 2.4.12 Oct 14, 2021
philwebb added a commit that referenced this issue Oct 15, 2021
@philwebb
Revert "Remove unnecessary bind-api dependency from test starter"
670d167 
This reverts commit 9867651.

See gh-28085
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
2.4.12
Development

No branches or pull requests
2 participants
@philwebb @mbhave