Skip to content

Add a test slice for Spring Data Cassandra #17490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add a test slice for Spring Data Cassandra #17490

wants to merge 1 commit into from

Conversation

ayudovin
Copy link
Contributor

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 11, 2019
@wilkinsona
Copy link
Member

Thanks very much for the PR, @ayudovin. As Phil said here we'd like to wait until we've tackled #16886 before implementing this. Your proposal still looks very useful, but we need to wait to see how things pan out with #16886 before making any necessary updates and merging it.

@wilkinsona wilkinsona added type: enhancement A general enhancement status: blocked An issue that's blocked on an external project change and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 11, 2019
@wilkinsona wilkinsona mentioned this pull request Jul 11, 2019
Closed
@ayudovin
Copy link
Contributor Author

@wilkinsona ok, I have got it, no problem

@philwebb philwebb added this to the 2.x milestone Dec 20, 2019
@wilkinsona wilkinsona removed the status: blocked An issue that's blocked on an external project change label Jul 7, 2020
@snicoll snicoll added the for: team-attention An issue we'd like other members of the team to review label Jul 8, 2020
@philwebb philwebb modified the milestones: 2.x, 2.4.x Jul 8, 2020
@philwebb philwebb added for: merge-with-amendments Needs some changes when we merge and removed for: team-attention An issue we'd like other members of the team to review labels Jul 8, 2020
snicoll pushed a commit to snicoll/spring-boot that referenced this pull request Aug 5, 2020
@ayudovin @snicoll
Add test slice for Spring Data Cassandra
e138bf3 
See spring-projectsgh-17490
snicoll added a commit to snicoll/spring-boot that referenced this pull request Aug 5, 2020
@snicoll
Polish "Add test slice for Spring Data Cassandra"
4efde35 
See spring-projectsgh-17490
@snicoll snicoll self-assigned this Aug 5, 2020
snicoll pushed a commit that referenced this pull request Aug 5, 2020
@ayudovin @snicoll
Add test slice for Spring Data Cassandra
ae152b1 
See gh-17490
snicoll added a commit that referenced this pull request Aug 5, 2020
@snicoll
Polish "Add test slice for Spring Data Cassandra"
313b2be 
See gh-17490
@snicoll snicoll closed this in b51e612 Aug 5, 2020
@snicoll snicoll modified the milestones: 2.4.x, 2.4.0-M2 Aug 5, 2020
@snicoll
Copy link
Member

snicoll commented Aug 5, 2020

@ayudovin thanks again. I've rebased and polished the support in 313b2be

@ayudovin
Copy link
Contributor Author

ayudovin commented Aug 5, 2020

@snicoll, thank you!

@wilkinsona wilkinsona changed the title A slice annotation to test Cassandra components Add a test slice for Spring Data Cassandra Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
for: merge-with-amendments Needs some changes when we merge type: enhancement A general enhancement
Projects
None yet
Milestone
2.4.0-M2
Development

Successfully merging this pull request may close these issues.
5 participants
@ayudovin @wilkinsona @snicoll @philwebb @spring-projects-issues