Skip to content

Support additional R2DBC pool properties #21219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

rodolphocouto
Copy link
Contributor

This PR adds some missing properties from R2DBC pool:

  • max-life-time
  • max-acquire-time
  • max-create-connection-time
  • validation-depth

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 29, 2020
@snicoll
Copy link
Member

snicoll commented Apr 29, 2020

Everyone, thank you for all the reviews, I think we're good now.

Copy link
Member

@snicoll snicoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I've made some suggestions.

I didn't find the tests that exercice the mapping of those properties. Please see R2dbcAutoConfigurationTests.

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label May 12, 2020
@snicoll
Copy link
Member

snicoll commented May 25, 2020

@rodolphocouto how is it going? Have you had a chance to look at the review?

@rodolphocouto
Copy link
Contributor Author

Hey @snicoll, thanks for your review. I started working on that today and I should finish it soon.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels May 26, 2020
@snicoll
Copy link
Member

snicoll commented Jun 15, 2020

@rodolphocouto thanks for the follow-up. Are you done with d3d38d2? I am asking as I've requested to complete the existing tests to exercise the code you've added. Thanks!

@snicoll snicoll added status: waiting-for-feedback We need additional information before we can continue and removed status: feedback-provided Feedback has been provided labels Jun 15, 2020
@rodolphocouto
Copy link
Contributor Author

I just added some tests on R2dbcProperties. I couldn't find a way to test ConnectionFactory or ConnectionPool because they don't expose those properties. Does that make sense to you?

@rodolphocouto rodolphocouto requested a review from snicoll June 16, 2020 16:46
@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jun 16, 2020
@snicoll snicoll removed status: feedback-provided Feedback has been provided status: waiting-for-triage An issue we've not yet triaged labels Jul 8, 2020
@snicoll snicoll added the type: enhancement A general enhancement label Jul 8, 2020
@snicoll snicoll added this to the 2.4.x milestone Jul 8, 2020
@snicoll snicoll self-assigned this Jul 8, 2020
@snicoll snicoll changed the title Added missing R2DBC pool properties Support additional R2DBC pool properties Jul 9, 2020
@snicoll
Copy link
Member

snicoll commented Jul 9, 2020

Reviewing the code, I've noticed 3 properties that have a Duration of zero to express the absence of a timeout. This looks really odd to me and I am not keen to bring such a default in auto-completion for our users.

We could fix that by having no default value for those 3 properties (the lack of a timeout value meaning no timeout is something we do elsewhere). And only map the value if it's non-null. I've also created an issue and I'd like some feedback before moving forward.

@snicoll snicoll added status: blocked An issue that's blocked on an external project change and removed status: blocked An issue that's blocked on an external project change labels Jul 9, 2020
@snicoll snicoll modified the milestones: 2.4.x, 2.4.0-M2 Jul 14, 2020
@snicoll
Copy link
Member

snicoll commented Jul 14, 2020

This is going to be changed in r2dbc-pool so let's go with the "no default" option for the time being. I'll add a test that will fail as soon as the default changes so that we remember we need to do something about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants