-
Notifications
You must be signed in to change notification settings - Fork 41.2k
Support additional R2DBC pool properties #21219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Everyone, thank you for all the reviews, I think we're good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I've made some suggestions.
I didn't find the tests that exercice the mapping of those properties. Please see R2dbcAutoConfigurationTests
.
.../main/java/org/springframework/boot/autoconfigure/r2dbc/ConnectionFactoryConfigurations.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/boot/autoconfigure/r2dbc/ConnectionFactoryConfigurations.java
Outdated
Show resolved
Hide resolved
...utoconfigure/src/main/java/org/springframework/boot/autoconfigure/r2dbc/R2dbcProperties.java
Show resolved
Hide resolved
...utoconfigure/src/main/java/org/springframework/boot/autoconfigure/r2dbc/R2dbcProperties.java
Outdated
Show resolved
Hide resolved
@rodolphocouto how is it going? Have you had a chance to look at the review? |
Hey @snicoll, thanks for your review. I started working on that today and I should finish it soon. |
@rodolphocouto thanks for the follow-up. Are you done with d3d38d2? I am asking as I've requested to complete the existing tests to exercise the code you've added. Thanks! |
I just added some tests on |
Reviewing the code, I've noticed 3 properties that have a We could fix that by having no default value for those 3 properties (the lack of a timeout value meaning no timeout is something we do elsewhere). And only map the value if it's non-null. I've also created an issue and I'd like some feedback before moving forward. |
This is going to be changed in |
This PR adds some missing properties from R2DBC pool: