-
Notifications
You must be signed in to change notification settings - Fork 41.2k
Add properties to control exceptions ignored by LdapTemplate #21289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add properties to control exceptions ignored by LdapTemplate #21289
Conversation
Thanks for the PR, @filiphr.
Where possible, we've been moving towards setting the defaults in the properties and then adding some tests to make sure that out defaults align with the target class's defaults. The default from our |
Makes sense. Do you perhaps have some test that you can point me to so I can have a look at it and add it for this as well? |
I found Lines 299 to 306 in ff3b05a
I'll do it like that for the |
* ignorePartialResultException - For ignoring PartialResultException when searching with the LdapTemplate * ignoreNameNotFoundException - For ignoring NameNotFoundException when searching with the LdapTemplate * ignoreSizeLimitExceededException - For ignoring SizeLimitExceededException when searching with the LdapTemplate
09e34fd
to
2972025
Compare
Thanks for the hint @wilkinsona. I've amended my commit with and added |
Thanks very much, @filiphr. I polished things a little bit in this commit, primarily to group the new properties under |
That's great @wilkinsona. Thanks a lot for merging it and for polishing it. I was not aware about the grouping for the other templates. |
Added properties:
ignorePartialResultException
- For ignoringPartialResultException
when searching with theLdapTemplate
ignoreNameNotFoundException
- For ignoringNameNotFoundException
when searching with theLdapTemplate
ignoreSizeLimitExceededException
- For ignoringSizeLimitExceededException
when searching with theLdapTemplate
I was not sure whether you prefer setting the defaults in the properties as they are done in the target class or use
null
and only set them when they are explicitly set. I can change it if you prefer to have the defaults in theLdapProperties