Skip to content

Support filtered scrape for Prometheus #21545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Support filtered scrape for Prometheus #21545

wants to merge 1 commit into from

Conversation

izeye
Copy link
Contributor

@izeye izeye commented May 23, 2020

This PR changes to support filtered scrape for Prometheus.

See gh-20371

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 23, 2020
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels May 26, 2020
@wilkinsona wilkinsona added this to the 2.x milestone May 26, 2020
@snicoll snicoll modified the milestones: 2.x, 2.4.x May 28, 2020
@snicoll snicoll self-assigned this Jun 5, 2020
@snicoll snicoll modified the milestones: 2.4.x, 2.4.0-M1 Jun 5, 2020
snicoll pushed a commit that referenced this pull request Jun 5, 2020
@izeye @snicoll
Support filtered scrape for Prometheus
cd1baf1 
See gh-21545
snicoll added a commit that referenced this pull request Jun 5, 2020
@snicoll
Polish "Support filtered scrape for Prometheus"
da5e8d7 
See gh-21545
@snicoll snicoll closed this in 6db4103 Jun 5, 2020
@snicoll
Copy link
Member

snicoll commented Jun 5, 2020

Well done @izeye, thanks a lot. I've polished the documentation in da5e8d7 as the second test you've added was shadowing the request/response sample of the existing one. I've reworked the doc to provide a section with request & sample output for each.

@izeye izeye deleted the filtered-scrape branch June 5, 2020 13:04
@izeye izeye mentioned this pull request Mar 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.4.0-M1
Development

Successfully merging this pull request may close these issues.
4 participants
@izeye @snicoll @wilkinsona @spring-projects-issues