Disable XML bean definition loading when spring.xml.ignore is true #22093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
reviewed
Jun 24, 2020
...ng-boot-project/spring-boot/src/main/java/org/springframework/boot/BeanDefinitionLoader.java
Outdated
Show resolved
Hide resolved
dreis2211
reviewed
Jun 24, 2020
...ng-boot-project/spring-boot/src/main/java/org/springframework/boot/BeanDefinitionLoader.java
Outdated
Show resolved
Hide resolved
This commit allows to set the XmlBeanDefinitionReader field from BeanDefinitionLoader to null in a way that allows the GraalVM native compiler to remove it from the native image when the spring.xml.ignore flag introduced by spring-projects/spring-framework#25151 is set to true. The purpose of this change is to allow smaller footprint on native images without requiring to use GraalVM native substitutions which are unmaintainable by nature and also to increase the consistency between JVM and native images. In order to effective, this optimization requires BeanDefinitionLoader class to be initialized at build time.
|
I have updated this PR to focus only on disabling the XML reader as suggested by @wilkinsona. I was initially confused by the fact that |
wilkinsona
changed the title
wilkinsona
added
theme: performance
wilkinsona
pushed a commit
that referenced
this pull request
Jun 25, 2020
This commit allows to set the XmlBeanDefinitionReader field from BeanDefinitionLoader to null in a way that allows the GraalVM native compiler to remove it from the native image when the spring.xml.ignore flag introduced by spring-projects/spring-framework#25151 is set to true. The purpose of this change is to allow smaller footprint on native images without requiring to use GraalVM native substitutions which are unmaintainable by nature and also to increase the consistency between JVM and native images. In order to effective, this optimization requires BeanDefinitionLoader class to be initialized at build time. See gh-22093
wilkinsona
added a commit
that referenced
this pull request
Jun 25, 2020
sdeleuze
added a commit
to sdeleuze/spring-native
that referenced
this pull request
Jun 25, 2020
Thanks to spring-projects/spring-boot#22093 which brings support of spring.xml.ignore flag natively to Spring Boot. See spring-atticgh-138
dsyer
pushed a commit
to scratches/spring-graalvm-native
that referenced
this pull request
Sep 23, 2020
Thanks to spring-projects/spring-boot#22093 which brings support of spring.xml.ignore flag natively to Spring Boot. See spring-atticgh-138
dsyer
pushed a commit
to scratches/spring-graalvm-native
that referenced
this pull request
Sep 23, 2020
Thanks to spring-projects/spring-boot#22093 which brings support of spring.xml.ignore flag natively to Spring Boot. See spring-atticgh-138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows to set the
XmlBeanDefinitionReaderfield fromBeanDefinitionLoadertonullin a way that allows the GraalVM native compiler to remove it from the native image when thespring.xml.ignoreflag introduced by spring-projects/spring-framework#25151 is set totrue. The Groovy reader which relies on the XML one is disabled as well when thespring.xml.ignore flagis set totrue.The purpose of this change is to allow smaller footprint on native images without requiring to use GraalVM native substitutions which are unmaintainable by nature and also to increase the consistency between JVM and native images.
In order to effective, this optimization requires
BeanDefinitionLoaderclass to be initialized at build time.