Add StatsD transport protocol configuration option #22125
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
kedar-joshi
reviewed
Jun 27, 2020
| @@ -1764,12 +1764,13 @@ You can also change the interval at which metrics are sent to Stackdriver: | |||
| ==== StatsD | |||
| The StatsD registry pushes metrics over UDP to a StatsD agent eagerly. | |||
| By default, metrics are exported to a {micrometer-registry-docs}/statsd[StatsD] agent running on your local machine. | |||
| The StatsD agent host and port to use can be provided using: | |||
| The StatsD agent host,port, and protocol to use can be provided using: | |||
There was a problem hiding this comment.
There should be a space after host, i.e. .. host, port, ...
wilkinsona
added
type: enhancement
wilkinsona
approved these changes
Jun 28, 2020
There was a problem hiding this comment.
This looks really complete. Thanks very much for the PR, @lndobryden.
wilkinsona
pushed a commit
that referenced
this pull request
Jun 29, 2020
wilkinsona
added a commit
that referenced
this pull request
Jun 29, 2020
|
@lndobryden Thanks very much for making your first contribution to Spring Boot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will expose the StatsD transport protocol configuration option as a configuration option for actuator. I have a need to use TCP for exporting StatsD to telegraf, the underlying micrometer library supports using TCP, but it is not yet exposed as a configuration property for Spring Boot.