Add a property to not create HealthIndicators from AbstractRoutingDatasources #22222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rce's when creatng HealthIndicator's
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
changed the title
wilkinsona
added
type: enhancement
wilkinsona
requested changes
Jul 6, 2020
There was a problem hiding this comment.
Thanks very much for the PR, @juliojgd. I've left a couple of comments related to using @ConfigurationProperties rather than @Value. If you have the time to make the suggested changes, that would be great. Don't worry if you don't as we can make the necessary amendments as part of merging this.
...gframework/boot/actuate/autoconfigure/jdbc/DataSourceHealthContributorAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...ator-autoconfigure/src/main/resources/META-INF/additional-spring-configuration-metadata.json
Outdated
Show resolved
Hide resolved
...ework/boot/actuate/autoconfigure/jdbc/DataSourceHealthContributorAutoConfigurationTests.java
Show resolved
Hide resolved
...ework/boot/actuate/autoconfigure/jdbc/DataSourceHealthContributorAutoConfigurationTests.java
Show resolved
Hide resolved
|
@wilkinsona Suggested changes done. Let me know if something else needs to be changed. |
wilkinsona
approved these changes
Jul 7, 2020
wilkinsona
removed
the
for: merge-with-amendments
wilkinsona
pushed a commit
that referenced
this pull request
Jul 7, 2020
wilkinsona
added a commit
that referenced
this pull request
Jul 7, 2020
|
@juliojgd Thanks very much for making your first contribution to Spring Boot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is about #22151