Skip to content

Switch Neo4j health checks to the new Neo4j driver #22302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Switch Neo4j health checks to the new Neo4j driver #22302

wants to merge 1 commit into from

Conversation

meistermeier
Copy link
Contributor

This commit replaces the Neo4j-OGM based health checks and metrics
with new ones based on the Neo4j Java driver.

This PR cannot get merged on its own because it depends on #22299

@meistermeier
Update Neo4j actuator to use the new Neo4j driver.
611f047 
This commit replaces the Neo4j-OGM based health checks and metrics
with new ones based on the Neo4j Java driver.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 10, 2020
@meistermeier meistermeier mentioned this pull request Jul 10, 2020
Closed
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 14, 2020
@wilkinsona wilkinsona added this to the 2.4.x milestone Jul 14, 2020
@wilkinsona wilkinsona added the for: team-attention An issue we'd like other members of the team to review label Jul 14, 2020
@snicoll snicoll removed the for: team-attention An issue we'd like other members of the team to review label Jul 18, 2020
@snicoll snicoll changed the title Update Neo4j actuator to use the new Neo4j driver. Update Neo4j actuator to use the new Neo4j driver Jul 28, 2020
@snicoll
Copy link
Member

snicoll commented Jul 28, 2020

I don't think that Neo4jMetrics belong here. After a discussion with @meistermeier, the plan is to move Neo4jMetrics to the Micrometer project. We will limit this PR to health checks.

Assuming the contribution to micrometer is accepted, we can resume integration of metrics in a separate issue.

@snicoll snicoll changed the title Update Neo4j actuator to use the new Neo4j driver Switch Neo4j health checks to the new Neo4j driver Jul 28, 2020
@snicoll snicoll self-assigned this Jul 28, 2020
@snicoll snicoll modified the milestones: 2.4.x, 2.4.0-M2 Jul 28, 2020
snicoll pushed a commit that referenced this pull request Jul 28, 2020
@meistermeier @snicoll
Update Neo4j health check to use the Neo4j Driver
c5a7815 
This commit replaces the Neo4j-OGM based health checks with one based on
the Neo4j Java driver. A Reactive variant is also added in this commit.

See gh-22302
snicoll added a commit that referenced this pull request Jul 28, 2020
@snicoll
Polish "Update Neo4j health check to use the Neo4j Driver"
c6fde1e 
See gh-22302
@snicoll snicoll closed this in 0482cc8 Jul 28, 2020
@meistermeier meistermeier deleted the feature/neo4j-actuator branch July 30, 2020 09:07
@meistermeier meistermeier mentioned this pull request Jul 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.4.0-M2
Development

Successfully merging this pull request may close these issues.
4 participants
@meistermeier @snicoll @wilkinsona @spring-projects-issues