Add configuration to disable Redis Cluster dynamic sources refresh #22571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an option to enable/disable the DynamicRefreshSources setting on the Lettuce cluster toplogy refresh options. Closes gh-22398
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
reviewed
Jul 27, 2020
| @@ -410,6 +410,13 @@ public Refresh getRefresh() { | |||
| */ | |||
| private boolean adaptive; | |||
|
|
|||
| /** | |||
| * Whether discovered nodes should be used as the source for the cluster | |||
| * topology. When set to {@literal false}, only the initial seed nodes | |||
There was a problem hiding this comment.
You can't use Javadoc tag here as the annotation processor don't handle them.
| * topology. When set to {@literal false}, only the initial seed nodes | ||
| * will be used as sources for topology discovery. | ||
| */ | ||
| private Boolean dynamicSources = null; |
There was a problem hiding this comment.
The null initialization here is unnecessary. The AP will figure out the right default for a wrapper type.
There was a problem hiding this comment.
I thought so but I noticed it explicitly specified in places like this. I will remove the redundant initialization.
snicoll
added
the
status: waiting-for-feedback
snicoll
added
type: enhancement
snicoll
pushed a commit
that referenced
this pull request
Aug 4, 2020
This commit adds an option to enable/disable the DynamicRefreshSources setting on the Lettuce cluster toplogy refresh options. See gh-22571
snicoll
added a commit
that referenced
this pull request
Aug 4, 2020
|
Thanks again Chris. I've decided to switch the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an option to enable/disable the DynamicRefreshSources setting on the Lettuce cluster toplogy refresh options.
Closes gh-22398