Skip to content

LiquibaseEndpoint does not report change sets from ancestor contexts #22681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

biergit
Copy link
Contributor

@biergit biergit commented Jul 30, 2020

Fix traversal of ApplicationContext hierarchy to resolve potential Liquibase beans
Fixes #22680

fix traversal of ApplicationContext hierarchy to resolve potential Liquibase beans
@pivotal-issuemaster
Copy link

@biergit Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@biergit This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary.

@wilkinsona
Copy link
Member

@biergit Thanks for the pull request. Can you please sign the CLA? The proposal will result in a change in functionality which means it is not considered to be an obvious fix.

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Jul 31, 2020
@pivotal-issuemaster
Copy link

@biergit Thank you for signing the Contributor License Agreement!

@biergit
Copy link
Contributor Author

biergit commented Jul 31, 2020

Ok @wilkinsona that wasn't obvious to me ;) I'm part of the closer family now.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jul 31, 2020
@wilkinsona wilkinsona changed the title Fix resolution of Liquibase beans LiquibaseEndpoint does not find reports change sets from ancestor contexts Jul 31, 2020
@wilkinsona wilkinsona self-assigned this Jul 31, 2020
@wilkinsona wilkinsona added type: bug A general bug and removed status: feedback-provided Feedback has been provided status: waiting-for-triage An issue we've not yet triaged labels Jul 31, 2020
@wilkinsona wilkinsona added this to the 2.2.x milestone Jul 31, 2020
@wilkinsona wilkinsona changed the title LiquibaseEndpoint does not find reports change sets from ancestor contexts LiquibaseEndpoint does not report change sets from ancestor contexts Jul 31, 2020
@wilkinsona
Copy link
Member

Thanks very much for making your first contribution to Spring Boot, @biergit. This has been fixed in 2.2, 2.3, and 2.4.

@wilkinsona wilkinsona modified the milestones: 2.2.x, 2.2.10 Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use loop variable ApplicationContext to determine all Liquibase beans
4 participants