Prefer non-reflective access to ConfigurationClassPostProcessor #22858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
If the ConfigurationClassPostProcessor has been provided via an instance supplier then we can use that to set the MetadataReaderFactory non-reflectively, instead of using a PropertyValue (and the BeanWrapper eventually). The old behaviour is left as a fallback - probably without a change in Spring Framework it will continue to be the default.
philwebb
added
theme: graal
type: enhancement
|
@dsyer I was looking to merge this but I'm a bit worried that it might cause early initialization of the |
|
Oh wait, ignore me. I see you do that in the |
philwebb
pushed a commit
that referenced
this pull request
Aug 11, 2020
Update `SharedMetadataReaderFactoryContextInitializer` to optionally support a `ConfigurationClassPostProcessor` provided via an instance `Supplier`. If the instance supplier is available then we can use that to set the `MetadataReaderFactory` non-reflectively, instead of using a `PropertyValue` (and the `BeanWrapper` eventually). The previous behavior is left as a fallback and without a change in Spring Framework will continue to be the default for most applications. See gh-22858
philwebb
added a commit
that referenced
this pull request
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
ConfigurationClassPostProcessorhas been provided via an instance supplier then we can use that to set theMetadataReaderFactorynon-reflectively, instead of using a PropertyValue (and theBeanWrappereventually).The old behavior is left as a fallback - probably without a change in Spring Framework it will continue to be the default.