Document how to discover the HTTP Port at Runtime for both Servlet and Reactive web apps #22898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The section about retrieving the bound port for an embedded web server had only the proper interface for servlet-based servers, not for reactive servers. It took me a while to figure it out, so adding what I found here might save other people the time that it cost me.
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
added
type: documentation
snicoll
changed the title
snicoll
pushed a commit
that referenced
this pull request
Aug 12, 2020
snicoll
added a commit
that referenced
this pull request
Aug 12, 2020
|
@johncfranco thank you for making your first contribution to Spring Boot. It turns out that How-To was a little bit outdated anyway as we have a common abstraction between Servlet-based and Reactive web apps. I've polished your contribution to mention how you can listen to a common event that works in both arrangements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The section about retrieving the bound port for an embedded web server had only the proper interface for servlet-based servers, not for reactive servers. It took me a while to figure it out, so adding what I found here might save other people the time that it cost me.