Support authentication from Docker daemon to private docker registry. #22972
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: enhancement
|
If I'm understanding it right, this is needed to Thank you in advance. |
|
Is there any documentation on how to use this? |
@trajano this issue is open and unresolved so there's nothing to be documented yet I am afraid. |
|
I mean shouldn't this PR also include a change in the documentation on how to use it? |
|
Merging the PR is in progress, with some changes and added documentation. |
This commit adds the ability to configure Docker image registry authentication credentials in the Maven and Gradle plugins. The authentication credentials are passed to the Docker daemon with all daemon API calls, and the daemon forwards the credentials to the image registry when necessary. This makes it possible to use builder and run images stored in a private Docker registry. See gh-22972
|
@wmz7year Thank you very much for the contribution. I made some changes in 86fa814 to refactor the code to better match project conventions and to add documentation. It took a while to test this, because using the |
@crimsonvspurple Apologies for missing this question earlier. The |
|
I could not use spring's image builder to push to ECR even after trying a lot of things. It builds as long as I don't try to push to ECR. The errors always came down to some auth header being missing. I wasn't using any private image but built image was being pushed to private ECR. I had to switch to jib which worked nicely. I will give it another shot later. |
|
@crimsonvspurple Support for pushing to a registry was added in 2.4.0-M4. Please see #21001 for details. |
…ameters Closes spring-projectsgh-22972 (cherry picked from commit 43e315f)
…ameters Closes spring-projectsgh-22972 (cherry picked from commit 43e315f)
see: #22836