Skip to content

Auto-configure ConcurrentKafkaListenerContainerFactory with a user-provided RecordFilterStrategy bean if available #22973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

anshlykov
Copy link
Contributor

Closes gh-22364

@snicoll
Copy link
Member

snicoll commented Aug 17, 2020

@anshlykov thank you for the PR. We have a configurer one can use to create a custom factory with the things we've auto-configured. This should have been applied there rather than directly on the connection factory. I've polished things up in 8c0318e

@anshlykov anshlykov deleted the gh-22364 branch August 27, 2020 09:26
@tjk5567764363
Copy link

@snicoll can support multi RecordFilterStrategy? such as CompositeRecordFilterStrategy

@snicoll
Copy link
Member

snicoll commented Sep 15, 2020

@tjk5567764363 I am not sure what you asking or what CompositeRecordFilterStrategy is. The issue updates the documentation that mentions a bean of type RecordFilterStrategy is considered. If your implementation uses a composite pattern in its implementation that'll work fine as long as you have a primary bean that implements RecordFilterStrategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-configure ConcurrentKafkaListenerContainerFactory with a user-provided RecordFilterStrategy bean if available
4 participants