Provide a property for configuring Spring AMQP's address shuffle mode #23091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
requested changes
Aug 26, 2020
| /** | ||
| * Shuffling mode for connecting host. Default mode is NONE. | ||
| */ | ||
| private String addressShuffleMode = "NONE"; |
There was a problem hiding this comment.
The enum should be exposed rather as it provides better metadata
| @@ -87,6 +89,11 @@ | |||
| */ | |||
| private String addresses; | |||
|
|
|||
| /** | |||
| * Shuffling mode for connecting host. Default mode is NONE. | |||
There was a problem hiding this comment.
The default value should not be documented as it's the role of the configuration metadata to do that (look at other keys for inspiration).
| * @see #setAddressShuffleMode(String) | ||
| * @see #getAddressShuffleMode() | ||
| */ | ||
| public AbstractConnectionFactory.AddressShuffleMode determineAddressShuffleMode() { |
There was a problem hiding this comment.
I don't think we should do that. Rather we should set whatever has been set by the user.
snicoll
added
the
status: waiting-for-feedback
|
@snicoll , i have edited what you mention. please re-review plz. |
spring-projects-issues
added
status: feedback-provided
snicoll
pushed a commit
that referenced
this pull request
Aug 27, 2020
snicoll
added a commit
that referenced
this pull request
Aug 27, 2020
snicoll
added
type: enhancement
|
@01045972746 thank you for making your first contribution to Spring Boot. I've polished your contribution and added a test. |
wilkinsona
changed the title
wilkinsona
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This support connecting to RabbitMQ clustered host addresses with shuffling.
https://docs.spring.io/spring-amqp/reference/html/#cluster
Because of
shuffle-addressesmode is deprecated, i have addedaddressShuffleModeproperty which isString.Please review and comment. Thanks.