Make @PropertyMapping support nested annotations #23146
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, annotations annotated with @PropertyMapping that contained nested annotation attributes would result in instances of TypeMappedAnnotation being used as properties. This usually led to errors due to not being able to convert those to Strings. This commit makes it so that nested annotations are recursively mapped to properties. This should allow for more complex configuration to be mapped from annotations.
|
@otaconix Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@otaconix Thank you for signing the Contributor License Agreement! |
philwebb
added
type: enhancement
philwebb
pushed a commit
that referenced
this pull request
Oct 28, 2020
Update `AnnotationsPropertySource` so that nested annotations are supported. Prior to this commit, annotations annotated with `@PropertyMapping` that contained nested annotation attributes would result in instances of `TypeMappedAnnotation` being used as properties. This usually led to errors due to not being able to convert those to Strings. This commit makes it so that nested annotations are recursively mapped to properties. This should allow for more complex configuration to be mapped from annotations. See gh-23146
philwebb
added a commit
that referenced
this pull request
Oct 28, 2020
|
Thanks very much for the very comprehensive pull-request. This has now been merged into master and will be in the 2.4 release. |
|
great job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, annotations annotated with
@PropertyMappingthat containednested annotation attributes would result in instances of
TypeMappedAnnotationbeing used as properties. This usually led to errors due to not being able to convert those to Strings.This commit makes it so that nested annotations are recursively mapped to properties. This should allow for more complex configuration to be mapped from annotations.