Allow types other than Date to be used in the "timestamp" MVC error model #23256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove casting timestamp to java.util.Date as the cast is not necessary and it prevents using other objects (e.g. java.time classes).
|
@lock14 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@lock14 Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: bug
philwebb
changed the title
philwebb
pushed a commit
that referenced
this pull request
Sep 12, 2020
Remove casting "timestamp" to `java.util.Date` in `ErrorMvcAutoConfiguration` as the cast is not necessary and it prevents other types (e.g. `java.time`) from being used. See gh-23256
philwebb
added a commit
that referenced
this pull request
Sep 12, 2020
|
Thanks very much for the PR @lock14. I've merged this into 2.2.x and it's also been forward merged to 2.3.x and 2.4.x. |
philwebb
added a commit
that referenced
this pull request
Sep 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove casting timestamp to java.util.Date as the cast is not necessary and it makes using other objects (e.g. java.time classes) for the timestamp more cumbersome (requires supplying a custom ErrorView instead of being able to use the default StaticView).