Configure the bootBuildInfo task lazily #23435
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@celcius112 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@celcius112 Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
Prior to this commit, the bootBuildInfo was configured eagerly. Configuring it lazily prevent this task from being configured when not explicitly needed. Also, the 'classes' and 'bootJar' tasks are now lazily configured, as the bootBuildInfo task required them eagerly.
wilkinsona
added
type: enhancement
|
@celcius112 Thanks very much for making your first contribution to Spring Boot. |
wilkinsona
pushed a commit
that referenced
this pull request
Sep 28, 2020
Prior to this commit, the bootBuildInfo was configured eagerly. Configuring it lazily prevent this task from being configured when not explicitly needed. Also, the 'classes' and 'bootJar' tasks are now lazily configured, as the bootBuildInfo task was causing them to be configured eagerly. See gh-23435
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #18881
Prior to this commit, the
bootBuildInfowas configured eagerly.Configuring it lazily prevent this task from being configured when not explicitly needed.
Also, the
classesandbootJartasks are now lazily configured, as thebootBuildInfotaskrequired them eagerly.
There are still some improvement possible for the
AutoConfigurationPlugin, but it requires a bit more work.