Add configuration option to configure RabbitConnectionFactory's channelRpcTimeout #23564
Conversation
Added the property channelRpcTimeout in RabbitProperties.java file to be configurable in RabbitAutoConfiguration
|
@jkhoward Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
mbhave
added
type: enhancement
|
@jkhoward Thank you for signing the Contributor License Agreement! |
wilkinsona
changed the title
| /** | ||
| * Channel RPC timeout. | ||
| */ | ||
| private Duration channelRpcTimeout; |
There was a problem hiding this comment.
May be annotate with @DurationUnit(ChronoUnit.MILLIS) (see field requestedHeartbeat)
The default duration is infinite, which may lead to a freeze of the Spring Boot application startup in some situations => may be a sensible default of 1 min would be wise?
There was a problem hiding this comment.
@pierre-sion the default is already ms so need to change the unit. In the original PR, no default value was set (null) and the mapping only applies if a non null value is provided. The default of 10 minutes is preserved but I've made that more explicit in a polish commit.
This commit adds a configuration option to configure RabbitConnectionFactory's channelRpcTimeout property. See gh-23564
|
@jkhoward nicely done and thank you for making your first contribution to Spring Boot. The default for this property is 10 minutes so I've polished that in c4e1b4f. |
Added the property channelRpcTimeout in RabbitProperties.java file to be
configurable in RabbitAutoConfiguration
Thank you for the OSD opportunity to learn! I hope you all made a lot of progress on this project today.