Deprecate HSQL in EmbeddedDatabaseConnection and add HSQLDB as its preferred replacement #23565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@desainidhi99 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@desainidhi99 Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
mbhave
added
type: enhancement
mbhave
pushed a commit
that referenced
this pull request
Oct 2, 2020
mbhave
added a commit
that referenced
this pull request
Oct 2, 2020
|
@desainidhi99 Thank you for your first contribution to Spring Boot! This has now been merged into master along with this polish commit. The polish commit was mainly replacing occurrences of the deprecated HSQL with HSQLDB. |
|
@mbhave - thank you for all your help on it :) |
wilkinsona
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-> Issue #23092 (Deprecate HSQL in EmbeddedDatabaseConnection and add HSQLDB as its preferred replacement).
-> PR is able to fix the issue by adding the enum hsqldb in the EmbeddedDatabaseConnection file and therey helping for consistency of connection name across different files.
-> Added deprecating annotation for old hsql connection name
-> Tests are added to verify the changes and ran locally with "pass" status.