Use JdbcTransactionManager in favor of DatasourceTransactionManager #23572
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
mdeinum
force-pushed
the
jdbc-transactionmanager
branch
from
7558e4f to
0113035
Compare
| @@ -47,17 +46,17 @@ | |||
| @ConditionalOnClass({ JdbcTemplate.class, TransactionManager.class }) | |||
| @AutoConfigureOrder(Ordered.LOWEST_PRECEDENCE) | |||
| @EnableConfigurationProperties(DataSourceProperties.class) | |||
| public class DataSourceTransactionManagerAutoConfiguration { | |||
| public class JdbcTransactionManagerAutoConfiguration { | |||
There was a problem hiding this comment.
That's a breaking change as the name of the class is public API.
There was a problem hiding this comment.
I did consider changing only the configuration to return a JdbcTransactionManager instead of a DataSourceTransactionManager. I can still do that and revert this rename and only keep the implementation change?
There was a problem hiding this comment.
Reverted the rename and only kept the config change.
There was a problem hiding this comment.
Thanks but I explicitly asked you to not act on it
I've added a note for myself in the review, no need to act on it now.
I might have to ask you to undo that based on further analysis.
There was a problem hiding this comment.
No problem. I assumed you meant the change from DataSourceTransactionManager to JdbcTransactionManager and not the change in the name of the configuration. If I need to change it again or add a migration path of sorts please let me know.
Spring 5.3 introduced the JdbcTransactionManager with exception translation on commit and rollback. With this commit this transaction manager is going to be used in favor of the DataSourceTransactionManager used previously.
mdeinum
force-pushed
the
jdbc-transactionmanager
branch
from
0113035 to
8a01411
Compare
snicoll
added
type: enhancement
|
Unfortunately, I made a typo while copying the reference of the issue. This was fixed by 9293b26 |
Spring 5.3 introduced the JdbcTransactionManager with exception translation
on commit and rollback. With this commit, this transaction manager is going
to be used in favour of the DataSourceTransactionManager used previously.