Skip to content

Add a FailureAnalyzer for ConfigDataNotFoundException #23633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add a FailureAnalyzer for ConfigDataNotFoundException #23633

wants to merge 2 commits into from

Conversation

Miehau
Copy link
Contributor

@Miehau Miehau commented Oct 11, 2020 •
edited by philwebb
Loading

As suggested by @dsyer, we could add a FailureAnalyzer for ConfigDataLocationNotFoundException .

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 11, 2020
@philwebb philwebb added type: enhancement A general enhancement for: merge-with-amendments Needs some changes when we merge and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 13, 2020
@philwebb philwebb added this to the 2.4.x milestone Oct 13, 2020
@philwebb philwebb mentioned this pull request Oct 13, 2020
Closed
@philwebb philwebb self-assigned this Oct 13, 2020
@philwebb philwebb mentioned this pull request Oct 15, 2020
Closed
@philwebb philwebb changed the title Implements FailureAnalyzer for ConfigDataLocationNotFoundException Add a FailureAnalyzer for ConfigDataNotFoundException Oct 15, 2020
philwebb pushed a commit that referenced this pull request Oct 15, 2020
@Miehau @philwebb
Add a FailureAnalyzer for ConfigDataNotFound
be7d697 
Add a `FailureAnalyzer` to deal with `ConfigDataNotFoundException`.

See gh-23633
philwebb added a commit that referenced this pull request Oct 15, 2020
@philwebb
Polish 'Add a FailureAnalyzer for ConfigDataNotFound'
e360e4a 
See gh-23633
@philwebb philwebb closed this in 759a5f0 Oct 15, 2020
@philwebb philwebb modified the milestones: 2.4.x, 2.4.0-M4 Oct 15, 2020
@philwebb
Copy link
Member

Thanks for the contribution @Miehau. I've made a few changes in e360e4a to improve the message and provide an action.

@Miehau
Copy link
Contributor Author

Miehau commented Oct 15, 2020

Ah, sorry @philwebb . I was quite busy this week and couldn't look at the build failure before.
I thought it was too obvious to come up with action for this one. Was trying to base this change on other Analyzers, but I lacked some understanding apparently.

@philwebb
Copy link
Member

No worries, it was a good starting point and I recently tweaked the exception hierarchy which made things easier. Thanks again for working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@philwebb philwebb

Labels
for: merge-with-amendments Needs some changes when we merge type: enhancement A general enhancement
Projects
None yet
Milestone
2.4.0-M4
Development

Successfully merging this pull request may close these issues.
3 participants
@Miehau @philwebb @spring-projects-issues