Add KafkaStream's CleanupConfig properties #23636
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
adrien-ben
force-pushed
the
kafka_streams_cleanup
branch
from
8ad0006 to
d6f1710
Compare
snicoll
added
type: enhancement
snicoll
pushed a commit
that referenced
this pull request
Oct 14, 2020
snicoll
added a commit
that referenced
this pull request
Oct 14, 2020
|
@adrien-ben thank you for making your first contribution to Spring Boot. I had started a review with a number of things to change and it turned out I had written the code anyway so I went ahead and polished your contribution. Going forward, please make sure to run the build and add the necessary tests that exercise the new behaviour. As the properties had no setter, there was no way the properties could be set to customise the cleanup behaviour. See b960fa3 for more details. |
|
@snicoll thanks for fixing and merging it. I pushed a bit early. I'll be more careful next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add properties for Spring Kafka's cleanup configuration.