Skip to content

Add reference to Ogham Spring Boot starters #24964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

aurelien-baudet
Copy link
Contributor

I would like to include Ogham in Spring Boot official starters.

The aim of Ogham is to simplify the code that sends email and SMS (more is coming like RCS).
You write the same code but still target different protocol/services (for example SMTP in dev, SendGrid in production).
You automatically use the template engine that is available in the classpath to design the content of your email or your SMS.
You also get rid of technical concerns (for example, images and styles are automatically inlined in the HTML of the email, you don't need to do it).
You also increase productivity while testing using testing tools.

There are more features, see user manual.

@pivotal-issuemaster
Copy link

@aurelien-baudet Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

Copy link
Member

@wilkinsona wilkinsona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the PR, @aurelien-baudet. I've made a couple of suggestions. Could you please take a look at them when you have a moment?

@@ -241,4 +241,9 @@ do as they were designed before this was clarified.
| https://github.com/knowm/XChange[XChange]
| https://github.com/cassandre-tech/cassandre-trading-bot

| https://groupe-sii.github.io/ogham/[Ogham]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list of starters is ordered alphabetically. Could you please move this entry further up the page so it comes immediately before the entry fo OkHTTP.

@@ -241,4 +241,9 @@ do as they were designed before this was clarified.
| https://github.com/knowm/XChange[XChange]
| https://github.com/cassandre-tech/cassandre-trading-bot

| https://groupe-sii.github.io/ogham/[Ogham]
a| * https://github.com/groupe-sii/ogham/tree/master/ogham-spring-boot-starter-all
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with the other entries, could you please remove the bullet points?

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 21, 2021
* keep alpahabetic order
* remove bullets
@wilkinsona wilkinsona added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 22, 2021
@wilkinsona wilkinsona added this to the 2.5.0-M2 milestone Jan 22, 2021
wilkinsona pushed a commit to wilkinsona/spring-boot that referenced this pull request Jan 22, 2021
wilkinsona added a commit to wilkinsona/spring-boot that referenced this pull request Jan 22, 2021
@wilkinsona
Copy link
Member

@aurelien-baudet Thanks very much for making your first contribution to Spring Boot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants