Support sending metrics to InfluxDB v2 #25721
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Micrometer 1.7.0-M1 adds support for InfluxDB v2 in addition to the existing support for InfluxDB v1. Some concepts have changed in v2. So we need additional properties for users to be able to configure where to write metrics and authenticate via token.
shakuzen
commented
Mar 17, 2021
| @@ -33,7 +35,7 @@ | |||
| public class InfluxProperties extends StepRegistryProperties { | |||
|
|
|||
| /** | |||
| * Tag that will be mapped to "host" when shipping metrics to Influx. | |||
| * Destination to write metrics when using an InfluxDB 1.x database. | |||
There was a problem hiding this comment.
The previous description was just wrong and some version of the updated description should be backported.
There was a problem hiding this comment.
Thanks Tommy. I've created: #25723
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
changed the title
snicoll
added
type: enhancement
snicoll
pushed a commit
that referenced
this pull request
Mar 17, 2021
snicoll
added a commit
that referenced
this pull request
Mar 17, 2021
That's a good idea. I've done that in 8808d5e. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Micrometer 1.7.0-M1 adds support for InfluxDB v2 in addition to the existing support for InfluxDB v1. Some concepts have changed in v2. So we need additional properties for users to be able to configure where to write metrics and authenticate via token.
Maybe we want to consider also updating the description of existing properties to note which are specific to v1. What do you think?