Skip to content

Include WebMvcRegistrations in @WebMvcTest #27823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Aug 27, 2021

WebMvcRegistrations should be treat as well as WebMvcConfigurer

@quaff
Copy link
Contributor Author

quaff commented Aug 31, 2021

@philwebb Would you take a look at this?

@philwebb
Copy link
Member

@quaff I think it looks sensible. @bclozel any concerns?

@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 31, 2021
@philwebb philwebb added this to the 2.6.x milestone Aug 31, 2021
@bclozel bclozel self-requested a review September 8, 2021 18:12
@snicoll snicoll changed the title Add WebMvcRegistrations to WebMvcTypeExcludeFilter Include WebMvcRegistrations in @WebMvcTest Sep 10, 2021
snicoll pushed a commit that referenced this pull request Sep 10, 2021
@snicoll snicoll closed this in 657b8ce Sep 10, 2021
@snicoll snicoll modified the milestones: 2.6.x, 2.6.0-M3 Sep 10, 2021
@snicoll snicoll self-assigned this Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants