Fix Integration fixedRate property setting
#28237
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `spring.integration.poller.fixed-rate` property must be set to the constructor of the `PeriodicTrigger` and its `fixedRate` flag should be set to `true`. The current code-base has it exactly opposite: the flag is set to `true` when `fixed-delay` is provided * Fix `IntegrationAutoConfiguration.asTrigger()` method for the proper `fixedRate` setting logic * Cover the change with a new test-case * Add a message handling verification to the `defaultPoller()` test to be sure that poller auto-configuration works as it is claimed
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: bug
snicoll
pushed a commit
that referenced
this pull request
Oct 13, 2021
The `spring.integration.poller.fixed-rate` property must be set to the constructor of the `PeriodicTrigger` and its `fixedRate` flag should be set to `true`. The current code-base has it exactly opposite: the flag is set to `true` when `fixed-delay` is provided. * Fix `IntegrationAutoConfiguration.asTrigger()` method for the proper `fixedRate` setting logic. * Cover the change with a new test-case * Add a message handling verification to the `defaultPoller()` test to be sure that poller auto-configuration works as it is claimed. See gh-28237
snicoll
added a commit
that referenced
this pull request
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
spring.integration.poller.fixed-ratepropertymust be set to the constructor of the
PeriodicTriggerand its
fixedRateflag should be set totrue.The current code-base has it exactly opposite:
the flag is set to
truewhenfixed-delayis providedIntegrationAutoConfiguration.asTrigger()methodfor the proper
fixedRatesetting logicdefaultPoller()test to be sure that poller auto-configuration works as it is claimed