Expose Elastic's apiKeyCredentials property #28400
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jonatan-ivanov
commented
Oct 20, 2021
| @@ -74,6 +76,12 @@ | |||
| */ | |||
| private String pipeline; | |||
|
|
|||
| /** | |||
| * Base64-encoded credentials string. If configured, it will be used for | |||
There was a problem hiding this comment.
I'm thinking if we should document how to create this credential string here or somewhere else in Boot, see:
There was a problem hiding this comment.
IMO, it shouldn't be documented in detail anywhere in Boot. I think the documentation belongs closer to its source so either in Micrometer's reference docs or in Elastic's.
wilkinsona
added
type: enhancement
wilkinsona
pushed a commit
that referenced
this pull request
Oct 21, 2021
wilkinsona
added a commit
that referenced
this pull request
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes
apiKeyCredentialsproperty for Elastic API Key authentication feature, recently added to Micrometer: