JUnit annotations may prevent a test context from being cached #28563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
I think it makes sense to ignore |
philwebb
added
for: team-attention
philwebb
pushed a commit
that referenced
this pull request
Nov 8, 2021
Update `ImportsContextCustomizer` to ignore JUnit annotations. See gh-28563
philwebb
added a commit
that referenced
this pull request
Nov 8, 2021
ledoyen
deleted the
ignore_junit_annotations_when_caching_test_contexts
branch
wilkinsona
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello spring-team 👋
As JUnit Jupiter comes with many new features through annotations (such as
@TestInstanceor@Order), it makes sens that they be ignored by the key created byImportsContextCustomizer.This is a small patch, but one can wonder if the key should not consider only
org.springframework.*annotations or supply an extension point for custom user-defined annotations to be ignored when creating the context caching key (part).Let me know if you need more contexts.
Best regards !