Skip to content

Rework Spring Session auto-configuration to use customizers #32554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

vpavic
Copy link
Contributor

@vpavic vpavic commented Sep 30, 2022

This PR reworks Spring Session auto-configuration to avoid extending Spring Session's configuration classes. Instead, those configuration classes are now imported and customizations are applied using dedicated (Reactive)SessionRepositoryCustomizer beans.

This commit reworks Spring Session auto-configuration to avoid extending Spring Session's configuration classes. Instead, those configuration classes are now imported and customization are applied using dedicated (Reactive)SessionRepositoryCustomizer beans.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 30, 2022
@wilkinsona wilkinsona added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 3, 2022
@wilkinsona wilkinsona added this to the 3.0.x milestone Oct 3, 2022
@wilkinsona wilkinsona added the status: on-hold We can't start working on this issue yet label Oct 3, 2022
@wilkinsona
Copy link
Member

On hold until we're ready to move to snapshots.

@vpavic
Copy link
Contributor Author

vpavic commented Oct 3, 2022

Is there a rough estimate when the move to snapshots is expected to be unblocked?

I'm asking because a lot of Spring Session's configuration infrastructure is set up the way it currently is because of reliance of Spring Boot's auto-configuration on inheritance, and the changes proposed here would allow Spring Session to evolve its configuration infrastructure. Having in mind the RCs are scheduled in just a little over 2 weeks from now, I'm trying to get a sense of the time we'll have to explore further improvements on Spring Session side.

@wilkinsona
Copy link
Member

wilkinsona commented Oct 3, 2022

We're trying to figure that out at the moment. Right now, it's looking like Boot will switch to snapshots of all the Spring projects on which it depends on Thursday (6 October).

@vpavic
Copy link
Contributor Author

vpavic commented Oct 3, 2022

Thanks. If the switch (and hopefully merge of this PR) happens by the end of this week, that would be great.

@wilkinsona wilkinsona removed the status: on-hold We can't start working on this issue yet label Oct 6, 2022
@wilkinsona wilkinsona self-assigned this Oct 6, 2022
wilkinsona pushed a commit that referenced this pull request Oct 6, 2022
This commit reworks Spring Session auto-configuration to avoid
extending Spring Session's configuration classes. Instead, those
configuration classes are now imported and customizations are
applied using dedicated (Reactive)SessionRepositoryCustomizer beans.

See gh-32554
@wilkinsona wilkinsona closed this in 479bd17 Oct 6, 2022
@wilkinsona wilkinsona modified the milestones: 3.0.x, 3.0.0-RC1 Oct 6, 2022
@wilkinsona
Copy link
Member

Thanks, @vpavic. The changes are now in main. I polished things a little in 7e47d3b to remove some inner-classes that were no longer necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants