Add property for maximum number of reactive sessions #38703
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
JohnNiang
force-pushed
the
feat/support-configuring-max-session-limit
branch
from
5ad31df to
a28e44f
Compare
wilkinsona
reviewed
Dec 7, 2023
There was a problem hiding this comment.
Thanks for the PR, @JohnNiang. I've left a few comments for your consideration.
...autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/ServerProperties.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/boot/autoconfigure/web/reactive/WebFluxAutoConfiguration.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/boot/autoconfigure/web/reactive/WebFluxAutoConfiguration.java
Outdated
Show resolved
Hide resolved
.../java/org/springframework/boot/autoconfigure/web/reactive/WebFluxAutoConfigurationTests.java
Outdated
Show resolved
Hide resolved
wilkinsona
added
the
status: waiting-for-feedback
JohnNiang
force-pushed
the
feat/support-configuring-max-session-limit
branch
from
a28e44f to
c4b7c3a
Compare
|
Hi @wilkinsona , thank you for code review. I have adjusted some of the code according to your feedback. |
spring-projects-issues
added
status: feedback-provided
JohnNiang
force-pushed
the
feat/support-configuring-max-session-limit
branch
from
c4b7c3a to
4ffda01
Compare
Signed-off-by: John Niang <[email protected]>
JohnNiang
force-pushed
the
feat/support-configuring-max-session-limit
branch
from
4ffda01 to
1b60420
Compare
mhalbritter
changed the title
philwebb
added
type: enhancement
mhalbritter
pushed a commit
that referenced
this pull request
Jan 10, 2024
Signed-off-by: John Niang <[email protected]> See gh-38703
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the maxinum number of sessions is 10,000 while using Reactive server. Our users always receive errors that reach the maxinum session limit. See here for source code.
This PR allows users to freely configure the maxinum number of sessions by setting property
server.reactive.session.max-sessions.