Skip to content

Cleanup java sources #38739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Cleanup java sources #38739

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Dec 12, 2023 •
edited
Loading

  1. use .isEmpty() where feasible
  2. remove unnecessary static modifier of inner record or interface type
  3. remove unnecessary final modifier of private or static method
  4. remove unnecessary toString()

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 12, 2023
@quaff quaff marked this pull request as draft December 12, 2023 03:20
@quaff
Cleanup java sources
4ade2ef 
1. use `.isEmpty()` where feasible
2. remove unnecessary `static` modifier of inner record or interface type
3. remove unnecessary `final` modifier of private or static method
4. remove unnecessary `toString()`
@quaff quaff marked this pull request as ready for review December 12, 2023 04:14
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 20, 2023
@philwebb philwebb added this to the 3.1.x milestone Dec 20, 2023
@philwebb philwebb mentioned this pull request Dec 20, 2023
Closed
@philwebb philwebb modified the milestones: 3.1.x, 3.1.7 Dec 20, 2023
philwebb pushed a commit that referenced this pull request Dec 20, 2023
@quaff @philwebb
Use .isEmpty() where feasible
ac18e30 
See gh-38739
philwebb pushed a commit that referenced this pull request Dec 20, 2023
@quaff @philwebb
Remove unnecessary static modifiers
d3a51e5 
See gh-38739
philwebb pushed a commit that referenced this pull request Dec 20, 2023
@quaff @philwebb
Remove unnecessary final modifiers
84f7c2d 
See gh-38739
philwebb pushed a commit that referenced this pull request Dec 20, 2023
@quaff @philwebb
Remove unnecessary extends Object from generic
b6e87ce 
See gh-38739
philwebb pushed a commit that referenced this pull request Dec 20, 2023
@quaff @philwebb
Remove unnecessary toString() calls
8599e5a 
See gh-38739
@philwebb philwebb closed this in ae79a7c Dec 20, 2023
@philwebb
Copy link
Member

Thanks very much @quaff. I've split up the commits and merged this into 3.1.x and 3.2.x.

@philwebb philwebb added type: task A general task and removed type: enhancement A general enhancement labels Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: task A general task
Projects
None yet
Milestone
3.1.7
Development

Successfully merging this pull request may close these issues.
3 participants
@quaff @philwebb @spring-projects-issues