Skip to content

Add a customizer for ProxyConnectionFactory.Builder from r2dbc-proxy #40555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ttddyy
Copy link
Contributor

@ttddyy ttddyy commented Apr 28, 2024

With upgrading to r2dbc-proxy 1.1.5.RELEASE(should be addressed by the dependency upgrade commits), this could be a change mentioned in #40010

NOTE:
Now the R2dbcObservationAutoConfiguration is more generic to r2dbc-proxy. It could be renamed to R2dbcProxyAutoConfiguration.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 28, 2024
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels May 2, 2024
@philwebb philwebb added this to the 3.4.x milestone May 2, 2024
@philwebb philwebb modified the milestones: 3.4.x, 3.5.x Jun 17, 2024
@mhalbritter mhalbritter self-assigned this Jun 28, 2024
mhalbritter pushed a commit that referenced this pull request Jun 28, 2024
mhalbritter added a commit that referenced this pull request Jun 28, 2024
@mhalbritter mhalbritter modified the milestones: 3.4.x, 3.4.0-M1 Jun 28, 2024
@mhalbritter
Copy link
Contributor

Thanks Tadaya! I've split the auto-configurations in two: one for the r2dbc proxy, and left the observation bits in R2dbcObservationAutoConfiguration.

@ttddyy ttddyy deleted the gh-40010_customizer branch July 1, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants