Skip to content

Fix typos in javadoc of BootstrapContext #41443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix typos in javadoc of BootstrapContext #41443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions spring-boot-project/spring-boot/src/main/java/org/springframework/boot/BootstrapContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public interface BootstrapContext {

/**
* Return an instance from the context if the type has been registered. The instance
* will be created it if it hasn't been accessed previously.
* will be created if it hasn't been accessed previously.
* @param <T> the instance type
* @param type the instance type
* @return the instance managed by the context
Expand All @@ -45,7 +45,7 @@ public interface BootstrapContext {

/**
* Return an instance from the context if the type has been registered. The instance
* will be created it if it hasn't been accessed previously.
* will be created if it hasn't been accessed previously.
* @param <T> the instance type
* @param type the instance type
* @param other the instance to use if the type has not been registered
Expand All @@ -55,7 +55,7 @@ public interface BootstrapContext {

/**
* Return an instance from the context if the type has been registered. The instance
* will be created it if it hasn't been accessed previously.
* will be created if it hasn't been accessed previously.
* @param <T> the instance type
* @param type the instance type
* @param other a supplier for the instance to use if the type has not been registered
Expand All @@ -65,7 +65,7 @@ public interface BootstrapContext {

/**
* Return an instance from the context if the type has been registered. The instance
* will be created it if it hasn't been accessed previously.
* will be created if it hasn't been accessed previously.
* @param <T> the instance type
* @param <X> the exception to throw if the type is not registered
* @param type the instance type
Expand All @@ -77,7 +77,7 @@ public interface BootstrapContext {
<T, X extends Throwable> T getOrElseThrow(Class<T> type, Supplier<? extends X> exceptionSupplier) throws X;

/**
* Return if a registration exists for the given type.
* Return {@code true} if a registration exists for the given type.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we aren't consistent across the codebase, I don't consider this one to be a typo or grammatical error. We should leave it as is for now please.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to do anything here. I dropped this change while merging the PR.

* @param <T> the instance type
* @param type the instance type
* @return {@code true} if the type has already been registered
Expand Down
Loading