Skip to content

Polish SpringApplication #42606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

gkdis6
Copy link
Contributor

@gkdis6 gkdis6 commented Oct 13, 2024

  • Reuse the webApplicationType variable in both methods to avoid redundant calls.
  • Simplify null handling for environmentType by adopting a consistent approach across both methods.
  • Enhance overall readability and reduce code duplication.

… eliminate duplicate code

- Reuse the `webApplicationType` variable in both methods to avoid redundant calls.
- Simplify null handling for environmentType by adopting a consistent approach across both methods.
- Enhance overall readability and reduce code duplication.
@pivotal-cla
Copy link

@gkdis6 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 13, 2024
@pivotal-cla
Copy link

@gkdis6 Thank you for signing the Contributor License Agreement!

@mhalbritter mhalbritter added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 14, 2024
@mhalbritter mhalbritter added this to the 3.2.x milestone Oct 14, 2024
@mhalbritter mhalbritter changed the title Refactor deduceEnvironmentClass and getOrCreateEnvironment methods to eliminate duplicate code Polish SpringApplication Oct 14, 2024
@mhalbritter mhalbritter self-assigned this Oct 14, 2024
@mhalbritter mhalbritter modified the milestones: 3.2.x, 3.4.x Oct 14, 2024
mhalbritter pushed a commit that referenced this pull request Oct 14, 2024
@mhalbritter
Copy link
Contributor

Thank you very much @gkdis6 and congratulations on your first contribution 🎉!

@mhalbritter mhalbritter modified the milestones: 3.4.x, 3.4.0-RC1 Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants