Mappings Endpoint support web-servlet router funtion #44172
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puppy4C
force-pushed
the
mappings-endpoint
branch
from
6b2a27d to
8ffb4af
Compare
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks for the PR, @Puppy4C, but it looks like it contains two changes that should be considered separately. Can you please update this proposal so that it only adds support for router functions on the servlet stack? The output that's produced should align as closely as possible with the current output for router functions on the reactive stack. Once that change has been reviewed and hopefully merged we can then consider improvements to the mapping information in a separate PR. |
wilkinsona
added
the
status: waiting-for-feedback
Signed-off-by: puppy4c <[email protected]>
Signed-off-by: puppy4c <[email protected]>
Signed-off-by: puppy4c <[email protected]>
Puppy4C
force-pushed
the
mappings-endpoint
branch
from
c40733b to
5d71765
Compare
|
Hi @wilkinsona , I have already removed another change. |
spring-projects-issues
added
status: feedback-provided
wilkinsona
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToStringVisitor).