Skip to content

@Frozen does not work on Map type #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spadou opened this issue Jul 6, 2021 · 0 comments
Closed

@Frozen does not work on Map type #1148

spadou opened this issue Jul 6, 2021 · 0 comments
Labels
type: bug A general bug
Milestone
3.1.12 (2020.0.12)

Comments

@spadou
Copy link

spadou commented Jul 6, 2021

The @Frozen annotation does not work to freeze a full Map, like so:

@Frozen Map<String, String> map;

It generate the following CQL:

map<text, text>

Instead of:

frozen<map<text, text>>

It work on List and Set, or to froze the key and value of the Map, but not to froze the full Map.

I tested this on version 3.2.2.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 6, 2021
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 6, 2021
@mp911de mp911de added this to the 3.1.12 (2020.0.12) milestone Jul 26, 2021
@mp911de mp911de changed the title @Frozen does not work on Map type @Frozen does not work on Map type Jul 26, 2021
mp911de added a commit that referenced this issue Jul 26, 2021
@mp911de
Properly consider frozen map creation.
73bcfe6 
We now correctly consider the Frozen annotation when annotating a property to define a frozen<map<…>> type. Previously we conly considered frozen key and value components instead of the entire type.

Closes #1148
mp911de added a commit that referenced this issue Jul 26, 2021
@mp911de
Properly consider frozen map creation.
5fc0003 
We now correctly consider the Frozen annotation when annotating a property to define a frozen<map<…>> type. Previously we only considered frozen key and value components instead of the entire type.

Closes #1148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
3.1.12 (2020.0.12)
Development

No branches or pull requests
3 participants
@mp911de @spadou @spring-projects-issues