Skip to content

CassandraAdminTemplate.createTable(…) does not apply table options #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-projects-issues opened this issue Dec 2, 2014 · 1 comment
Closed

CassandraAdminTemplate.createTable(…) does not apply table options #359

spring-projects-issues opened this issue Dec 2, 2014 · 1 comment
Labels
type: bug A general bug
Milestone
3.4.13 (2021.2.13)

Comments

@spring-projects-issues
Copy link

Jens Rantil opened DATACASS-188 and commented

Thought I had reported this previously, but couldn't find any mention of it.

spring-data-cassandra/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/config/CassandraSessionFactoryBean.java

Line 99 in ff41674

admin.createTable(false, entity.getTableName(), entity.getType(), null); // TODO: allow spec of table options
mentions a TODO for this, so it does not seem to be supported.

Specifically, I'd like to be able to set compaction strategy. This is a showstopper for us to use the SchemaActions functionality that Spring Data Cassandra comes with. Currently I have implemented table creation as a custom repository method.

Let me know if this is a duplicate of preexisting ticket

1 votes, 2 watchers
@spring-projects-issues spring-projects-issues added the type: enhancement A general enhancement label Dec 31, 2020
@mipo256 mipo256 mentioned this issue May 26, 2023
Closed
@mp911de mp911de added type: bug A general bug and removed type: enhancement A general enhancement labels Jun 7, 2023
@mp911de mp911de changed the title Support table options when creating tables [DATACASS-188] CassandraAdminTemplate.createTable(…) does not apply table options Jun 7, 2023
@mp911de mp911de added this to the 3.4.13 (2021.2.13) milestone Jun 7, 2023
mp911de pushed a commit that referenced this issue Jun 7, 2023
@mipo256 @mp911de
Correctly apply TableOptions through CassandraAdminTemplate.createTab…
f6e56e4 
…le(…).

Closes: #359
Original pull request: #1385
mp911de pushed a commit that referenced this issue Jun 7, 2023
@mipo256 @mp911de
Polishing.
d1d2840 
See: #359
Original pull request: #1385
mp911de added a commit that referenced this issue Jun 7, 2023
@mp911de
Polishing.
ca17fde 
Add Javadoc. Reformat code.

See: #359
Original pull request: #1385
mp911de pushed a commit that referenced this issue Jun 7, 2023
@mipo256 @mp911de
Correctly apply TableOptions through CassandraAdminTemplate.createTab…
6c193c6 
…le(…).

Closes: #359
Original pull request: #1385
mp911de pushed a commit that referenced this issue Jun 7, 2023
@mipo256 @mp911de
Polishing.
cf47ae4 
See: #359
Original pull request: #1385
mp911de added a commit that referenced this issue Jun 7, 2023
@mp911de
Polishing.
b1f91f6 
Add Javadoc. Reformat code.

See: #359
Original pull request: #1385
@mp911de
Copy link
Member

mp911de commented Jun 7, 2023

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this as completed Jun 7, 2023
@mp911de mp911de closed this as completed in cd444b2 Jun 7, 2023
mp911de pushed a commit that referenced this issue Jun 7, 2023
@mipo256 @mp911de
Polishing.
1d3a485 
See: #359
Original pull request: #1385
mp911de added a commit that referenced this issue Jun 7, 2023
@mp911de
Polishing.
2d250bb 
Add Javadoc. Reformat code.

See: #359
Original pull request: #1385
mp911de pushed a commit that referenced this issue Jun 7, 2023
@mipo256 @mp911de
Correctly apply TableOptions through CassandraAdminTemplate.createTab…
aa07755 
…le(…).

Closes: #359
Original pull request: #1385
mp911de added a commit that referenced this issue Jun 7, 2023
@mp911de
Polishing.
0c77ac6 
Add Javadoc. Reformat code.

See: #359
Original pull request: #1385
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
3.4.13 (2021.2.13)
Development

No branches or pull requests
2 participants
@mp911de @spring-projects-issues