[Test case DATACMNS-753] parsing of Sort fails to fallback properly #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shredder121
force-pushed
the
DATACMNS-753
branch
from
e1ee7b6 to
f596a95
Compare
Shredder121
force-pushed
the
DATACMNS-753
branch
from
f596a95 to
6c18f8d
Compare
Shredder121
changed the title
odrotbohm
pushed a commit
that referenced
this pull request
Sep 9, 2015
…ing defaults for empty parameter. Related ticket: DATACMNS-408. Original pull request: #138.
odrotbohm
added a commit
that referenced
this pull request
Sep 9, 2015
We now correctly inspect the sort parameter values and also fall back to the default if a single, empty parameter value is given. Related ticket: DATACMNS-408. Related pull request: #138.
odrotbohm
pushed a commit
that referenced
this pull request
Sep 9, 2015
…ing defaults for empty parameter. Related ticket: DATACMNS-408. Original pull request: #138.
odrotbohm
added a commit
that referenced
this pull request
Sep 9, 2015
We now correctly inspect the sort parameter values and also fall back to the default if a single, empty parameter value is given. Related ticket: DATACMNS-408. Related pull request: #138.
odrotbohm
pushed a commit
that referenced
this pull request
Sep 9, 2015
…ing defaults for empty parameter. Related ticket: DATACMNS-408. Original pull request: #138.
odrotbohm
added a commit
that referenced
this pull request
Sep 9, 2015
We now correctly inspect the sort parameter values and also fall back to the default if a single, empty parameter value is given. Related ticket: DATACMNS-408. Related pull request: #138.
|
That's merged and a fix applied, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test cases of
DATACMNS-408included a input ofnull, but a request with?sort=means that the parameter is"".Discussion https://jira.spring.io/browse/DATACMNS-753.