Skip to content

DATACMNS-853 - Support interface entity types using generated property accessors. #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

mp911de
Copy link
Member

@mp911de mp911de commented May 6, 2016

Property accessors (getter and setter) defined on an interface require a different instruction opcode for invoking methods. We now distinguish whether a property accessor is defined on an interface and use either INVOKEINTERFACE or INVOKEVIRTUAL otherwise.


Related tickets: DATACMNS-853, SGF-494
Related pull request: #160

mp911de and others added 4 commits May 6, 2016 09:27
…erface types with the class-generating accessor.

Prepare issue branch.
…nterface-based entities using the ClassGeneratingPropertyAccessorFactory.
Remove links from see tags.
…y accessors.

Property accessors (getter and setter) defined on an interface require a different instruction opcode for invoking methods. We now distinguish whether a property accessor is defined on an interface and use either INVOKEINTERFACE or INVOKEVIRTUAL otherwise.
odrotbohm pushed a commit that referenced this pull request May 12, 2016
Reproduce issue accessing persistent properties from interface-based entities using the ClassGeneratingPropertyAccessorFactory.

Related tickets: DATACMNS-809.
Original pull request: #161.
Related pull request: #160.
odrotbohm pushed a commit that referenced this pull request May 12, 2016
…y accessors.

Property accessors (getter and setter) defined on an interface require a different instruction opcode for invoking methods. We now distinguish whether a property accessor is defined on an interface and use either INVOKEINTERFACE or INVOKEVIRTUAL otherwise.

Related tickets: DATACMNS-809.
Original pull request: #161.
Related pull request: #160.
odrotbohm added a commit that referenced this pull request May 12, 2016
Simplified test case. Formatting in ClassGeneratingPropertyAccessorFactory.

Related tickets: DATACMNS-809.
Original pull request: #161.
Related pull request: #160.
@odrotbohm odrotbohm self-assigned this May 12, 2016
@odrotbohm
Copy link
Member

That's merged, thanks!

@odrotbohm odrotbohm closed this May 12, 2016
@odrotbohm odrotbohm deleted the issues/DATACMNS-853 branch May 25, 2016 15:09
Aloren pushed a commit to Aloren/spring-data-commons that referenced this pull request Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants